Deprecate Package.load, use PackageManager.load instead
#2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order for the dependency injection approach to work, we need to be able to override every single instance of `Package.load`. We could not override `Package.load` itself as it is a static function. However, in the process of adding support for path-based dependencies to the test suite, it became obvious that the functionality offered by `Package.load` is actually better suited for the `PackageManager`. Deprecating `Package.load` confirms this: Not a single call was outside of `PackageManager`, and no extra parameter had to be provided anywhere to make this work. This also nicely simplifies the `TestPackageManager` implementation, as we can now overload `load` and let `getPackage` alone.
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 17 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5318568 bin/dub
rough build time=65sFull build output |
thewilsonator
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for the dependency injection approach to work, we need to be able to override every single instance of
Package.load. We could not overridePackage.loaditself as it is a static function.However, in the process of adding support for path-based dependencies to the test suite, it became obvious that the functionality offered by
Package.loadis actually better suited for thePackageManager. DeprecatingPackage.loadconfirms this: Not a single call was outside ofPackageManager, and no extra parameter had to be provided anywhere to make this work.This also nicely simplifies the
TestPackageManagerimplementation, as we can now overloadloadand letgetPackagealone.